Adar Dembo has posted comments on this change.

Change subject: build: improve build to better indicate what part failed
......................................................................


Patch Set 4:

(2 comments)

http://gerrit.cloudera.org:8080/#/c/1816/4/build-support/jenkins/build-and-test.sh
File build-support/jenkins/build-and-test.sh:

Line 278:     EXIT_STATUS=1
The downside to this new approach is that we're no longer preserving the 
original exit status. Can't you do something like this:

...dist_test.py || EXIT_STATUS=$?
if [ $EXIT_STATUS -ne 0 ]; then
  FAILURES="$FAILURES..."
fi


Line 279:     FAILURES="$FAILURES"$'Could not submit distributed test job'
What's the $ inside the line do? Or does the shell just pass it through as-is?


-- 
To view, visit http://gerrit.cloudera.org:8080/1816
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I63b7d6c71aecaf61ab36f8fc6cedbfe1f63c6bbe
Gerrit-PatchSet: 4
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Todd Lipcon <[email protected]>
Gerrit-Reviewer: Adar Dembo <[email protected]>
Gerrit-Reviewer: Jean-Daniel Cryans
Gerrit-Reviewer: Mike Percy <[email protected]>
Gerrit-Reviewer: Todd Lipcon <[email protected]>
Gerrit-HasComments: Yes

Reply via email to