Todd Lipcon has posted comments on this change. Change subject: [java] waitForTabletServers should belong to the mini cluster ......................................................................
Patch Set 4: (2 comments) http://gerrit.cloudera.org:8080/#/c/1875/4/java/kudu-client/src/test/java/org/kududb/client/MiniKuduCluster.java File java/kudu-client/src/test/java/org/kududb/client/MiniKuduCluster.java: Line 69: private final int defaultTimeout; add units to name Line 410: public MiniKuduClusterBuilder defaultTimeout(int defaultTimeout) { this needs some javadoc (not obvious what operations this timeout applies to). Also should have the name 'millis' or 'ms' so the units are obvious -- To view, visit http://gerrit.cloudera.org:8080/1875 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I527b09e3dc530f186a7f5cf141c3f460613cf51c Gerrit-PatchSet: 4 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Jean-Daniel Cryans Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Dan Burkert <[email protected]> Gerrit-Reviewer: Internal Jenkins Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Mike Percy <[email protected]> Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-HasComments: Yes
