Adar Dembo has posted comments on this change. Change subject: Update to new cpplint, fix warnings ......................................................................
Patch Set 2: Code-Review+2 (2 comments) Feel free to ignore the nits. http://gerrit.cloudera.org:8080/#/c/1808/2/src/kudu/util/errno-test.cc File src/kudu/util/errno-test.cc: Line 18: #include <gtest/gtest.h> Nit: doesn't this qualify as a "Other libraries' .h files", thus coming after the string inclusion? http://gerrit.cloudera.org:8080/#/c/1808/2/src/kudu/util/errno.cc File src/kudu/util/errno.cc: Line 19: #include "kudu/util/logging.h" Nit: this should be included after string.h, right? Only errno.h should come first. -- To view, visit http://gerrit.cloudera.org:8080/1808 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I197188d5929a4c97c8f138ef790d5df4b8b2be74 Gerrit-PatchSet: 2 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Todd Lipcon <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Dan Burkert <[email protected]> Gerrit-Reviewer: Internal Jenkins Gerrit-Reviewer: Kudu Jenkins Gerrit-HasComments: Yes
