Adar Dembo has posted comments on this change.

Change subject: client: fix missing includes in scan_batch.h
......................................................................


Patch Set 1:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/1896/1/src/kudu/client/client_samples-test.sh
File src/kudu/client/client_samples-test.sh:

Line 67:     set +x
What's the purpose of set +x here? I don't see an equivalent "set -x" that 
we're disabling...

Oh, nm, it's in the hashbang. In that case, could you remove the set -e on line 
24?


-- 
To view, visit http://gerrit.cloudera.org:8080/1896
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I8e10f406c80dff7cbc61ca609d8d2bde737b91b6
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Todd Lipcon <[email protected]>
Gerrit-Reviewer: Adar Dembo <[email protected]>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-HasComments: Yes

Reply via email to