Mike Percy has posted comments on this change. Change subject: Add more thorough instructions for building docs and site ......................................................................
Patch Set 2: (5 comments) http://gerrit.cloudera.org:8080/#/c/1581/2/README.adoc File README.adoc: Line 295: To build the documentation or the site, the pre-requisites for building Kudu > Nit: in installation.adoc, we spell it "prerequisites". Can you do that her ok, i can do that Line 300: $ sudo apt-get install ruby ruby-devel xsltproc # for Ubuntu > Can you reconcile this with the doc prerequisites found in installation.ado I am just going to remove that section from installation.adoc Line 314: This will invoke `docs/support/scripts/make_docs.sh`, and will place the > Nit: the name of the script feels like an unnecessary implementation detail ok Line 329: the 'gh-pages' branch and use `make_docs.sh` to generate the HTML documentation > Nit: likewise, make_docs.sh here feels like an unnecessary name drop. Someo i don't see how it hurts anything but i can remove it http://gerrit.cloudera.org:8080/#/c/1581/2/docs/support/scripts/make_site.sh File docs/support/scripts/make_site.sh: Line 42: rm -rf "$SOURCE_ROOT/CMakeCache.txt" "$SOURCE_ROOT/CMakeFiles" > This is one of the reasons I want to forbid building in the source director well, i need this, since i currently build in tree. and i use ninja -- To view, visit http://gerrit.cloudera.org:8080/1581 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic1cde866d421a96b3803c236333bc1e70ee17f51 Gerrit-PatchSet: 2 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Mike Percy <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Mike Percy <[email protected]> Gerrit-Reviewer: Misty Stanley-Jones <[email protected]> Gerrit-HasComments: Yes
