Todd Lipcon has posted comments on this change. Change subject: Use 'kqueue' instead of 'select' for the rpc event loop in Mac OS X ......................................................................
Patch Set 1: (2 comments) http://gerrit.cloudera.org:8080/#/c/1897/1//COMMIT_MSG Commit Message: Line 10: which breaks rpc-test and often other tests. I'm curious which test in rpc-test makes more than 1000 connections... I don't remember there being such and don't see it on a quick review of the code. Do we have an epoll leak that we should be concerned about or something? would be interested to see an lsof or somesuch. http://gerrit.cloudera.org:8080/#/c/1897/1/src/kudu/rpc/reactor.cc File src/kudu/rpc/reactor.cc: Line 75: // When compiling on Mac OS X use 'kqueque' instead of the default, 'select', for the event loop, typo. also I think you should indent this 2 spaces, or perhaps move it above the function and do something like: #if !defined(__APPLE__) static const int kDefaultLibEvFlags = ev::AUTO; #else ... #endif so you dont have the awkward ifdef-inside-an-initializer-list thing going on -- To view, visit http://gerrit.cloudera.org:8080/1897 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8daa3d02c7e28952eecd9e2ce56cadb8b14c418c Gerrit-PatchSet: 1 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: David Ribeiro Alves <[email protected]> Gerrit-Reviewer: Dan Burkert <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-HasComments: Yes
