Adar Dembo has posted comments on this change. Change subject: cmake: require out-of-tree builds ......................................................................
Patch Set 12: > Does this address my concerns? If not, now that we have sane > defaults, maybe it's ok to allow in tree builds (at least through > some overriding dlag)? I'd like to walk through the Eclipse git integration with you to see if we can't make it work with sibling directories. Maybe we can do that on Thursday? Will you be in the office? Alternatively, you can walk me through setting it up on my own laptop and then I can play around with it. If we can't figure it out, I'll add an override for the in-tree build requirement. -- To view, visit http://gerrit.cloudera.org:8080/1762 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I57a9eab7d35419a3668b9dce384a049cddd1afef Gerrit-PatchSet: 12 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Adar Dembo <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Dan Burkert <[email protected]> Gerrit-Reviewer: David Ribeiro Alves <[email protected]> Gerrit-Reviewer: Internal Jenkins Gerrit-Reviewer: Jean-Daniel Cryans Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Mike Percy <[email protected]> Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-HasComments: No
