Jean-Daniel Cryans has posted comments on this change. Change subject: add async method to locate table ......................................................................
Patch Set 1: (4 comments) Thanks for taking care of this, we do have a hole right now. Some things to fix but looks good overall. http://gerrit.cloudera.org:8080/#/c/1916/1/java/kudu-client/src/main/java/org/kududb/client/AsyncKuduClient.java File java/kudu-client/src/main/java/org/kududb/client/AsyncKuduClient.java: Line 1034: + deadlineTracker.getDeadline())); Isn't the toString method giving better details? Why change it? Line 1040: return d.addBothDeferring( Use AsyncUtil.addCallbacksDeferring instead, because I don't think you'll get a GetTableLocationsResponsePB on the errback path. Line 1087: public Deferred<List<LocatedTablet>> locateTable(final String tableId, Why public? http://gerrit.cloudera.org:8080/#/c/1916/1/java/kudu-client/src/main/java/org/kududb/client/KuduTable.java File java/kudu-client/src/main/java/org/kududb/client/KuduTable.java: Line 151: public Deferred<List<LocatedTablet>> asyncGetTabletsLocations( This new method isn't being tested. -- To view, visit http://gerrit.cloudera.org:8080/1916 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0868ed77366ff7d45f92f99dfd033c244d53b48f Gerrit-PatchSet: 1 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: zhen.zhang <[email protected]> Gerrit-Reviewer: Jean-Daniel Cryans Gerrit-Reviewer: Kudu Jenkins Gerrit-HasComments: Yes
