Mike Percy has posted comments on this change. Change subject: Mark peer responsive when remote bootstrap is in progress ......................................................................
Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/1759/2/src/kudu/consensus/consensus_peers.cc File src/kudu/consensus/consensus_peers.cc: Line 309: if (!(rb_response_.error().code() == > How about ALREADY_INPROGRESS ? So maybe it can be used in other future scen ALREADY_IN_PROGRESS seems fine as well. As long as it would be unique "in context". > in the future this call may became async I think it would still make sense as an async call because it can do a sanity check first before initiating the actual remote bootstrapping work, so it could be partially sync/async like many other calls like AddServer() etc. -- To view, visit http://gerrit.cloudera.org:8080/1759 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic41f2ad31c437f6ab976987262d8b35f9aa9f3ad Gerrit-PatchSet: 2 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Binglin Chang <[email protected]> Gerrit-Reviewer: Binglin Chang <[email protected]> Gerrit-Reviewer: Internal Jenkins Gerrit-Reviewer: Mike Percy <[email protected]> Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-HasComments: Yes
