Todd Lipcon has posted comments on this change.

Change subject: KUDU-1317 (part 2): decay the replica creation load on TS lazily
......................................................................


Patch Set 1:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/1979/1/src/kudu/master/ts_descriptor.h
File src/kudu/master/ts_descriptor.h:

Line 93:   void IncrementRecentReplicaCreations();
> Add some documentation? Should mention that it also does time-based decay, 
I'll add some doc, but probably shouldn't mention the time-based decay 
happening, because that's essentially "transparent" -- necessary to make sure 
that the decay calculation is correct, but an impl detail


-- 
To view, visit http://gerrit.cloudera.org:8080/1979
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I15899b8bf221f334fdec5983e1b5d93cc57fab3b
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Todd Lipcon <[email protected]>
Gerrit-Reviewer: Adar Dembo <[email protected]>
Gerrit-Reviewer: Binglin Chang <[email protected]>
Gerrit-Reviewer: Jean-Daniel Cryans
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <[email protected]>
Gerrit-HasComments: Yes

Reply via email to