Jean-Daniel Cryans has posted comments on this change. Change subject: KUDU-1272: better error messages when client deadlines expire ......................................................................
Patch Set 1: Seems like we'd want to centralize the checking of deadline, it's always the same checks. Also, in the Java client each RPC has its name in a string so we don't need to sprinkle the actual name of the function around the code, would that be doable here? Regarding the spaghetti code, is that part of the stuff you were telling me you'll have to rewrite? -- To view, visit http://gerrit.cloudera.org:8080/1986 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iee294fd5d348fee37324d1bbc4119c20fc0299c2 Gerrit-PatchSet: 1 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Adar Dembo <[email protected]> Gerrit-Reviewer: Jean-Daniel Cryans Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-HasComments: No
