Hello Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/1983
to look at the new patch set (#4).
Change subject: tsan: remove libstdcxx race annotations
......................................................................
tsan: remove libstdcxx race annotations
Now that we run with a TSAN-instrumented libstdcxx, we no longer need to
suppress various std::string and shared_ptr functions.
However, the version of libstdcxx that we run against has a few minor
data races that don't cause much trouble in practice, but do trip up
TSAN. So, this adds two patches to libstdcxx to fix the issues:
- the first is an upstream patch[1] which fixes std::string
- the second is a similar patch for tr1::shared_ptr which is still used in the
client code. This patch isn't upstream, but basically just follows the example
from the C++11 shared_ptr implementation.
With these fixes, TSAN seems to run cleanly.
[1] https://gcc.gnu.org/viewcvs/gcc?view=revision&revision=227403
Change-Id: Iada66d777c1a1aa348759b5697706e6bcd335945
---
M build-support/tsan-suppressions.txt
M thirdparty/download-thirdparty.sh
A thirdparty/patches/libstdcxx-fix-string-dtor.patch
A thirdparty/patches/libstdcxx-fix-tr1-shared-ptr.patch
4 files changed, 84 insertions(+), 10 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/83/1983/4
--
To view, visit http://gerrit.cloudera.org:8080/1983
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Iada66d777c1a1aa348759b5697706e6bcd335945
Gerrit-PatchSet: 4
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Todd Lipcon <[email protected]>
Gerrit-Reviewer: Kudu Jenkins
