Todd Lipcon has posted comments on this change. Change subject: Remove TSAN suppressions for protobuf ......................................................................
Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#/c/1990/3/thirdparty/build-definitions.sh File thirdparty/build-definitions.sh: Line 175: # We build protobuf in both instrumented and non-instrumented modes. > gflags, glog, gperftools, gmock, snappy, and crcutil. Oh, I see... forgot about that bit. My guess this is a specific issue with the protobuf build not having its dependencies 100% right, and perhaps the other ones don't have this issue. I'd say "dont fix it if it aint broken" here, whereas we have proof that the protobuf one's broken. Here's a disassembly of a particular function I was having issues with without the make distclean: https://gist.github.com/toddlipcon/4480fe57e3edf82802b0 and with the distclean: https://gist.github.com/toddlipcon/b855ddf3ee33042f414c Note that the "with clean" one has the tsan func entry calls, whereas the other one didn't. -- To view, visit http://gerrit.cloudera.org:8080/1990 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0b4a2066dfc4b4e83c5c0a35bb8e5aa8f42d9147 Gerrit-PatchSet: 3 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Todd Lipcon <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: David Ribeiro Alves <[email protected]> Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-HasComments: Yes
