David Ribeiro Alves has posted comments on this change. Change subject: KUDU-980 - Fix timestamp printing in c++ ......................................................................
Patch Set 6: (2 comments) http://gerrit.cloudera.org:8080/#/c/965/6/src/kudu/common/types.h File src/kudu/common/types.h: Line 371: char time_up_to_secs[20]; > The time_up_to_secs and time buffers aren't big enough for time INT64_MIN. corrected that and added test for min and max. Line 372: strftime(time_up_to_secs, 20, kDateFormat, &tm_info); > s/20/sizeof(time_up_to_secs)/ Done -- To view, visit http://gerrit.cloudera.org:8080/965 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I97eb088a4d0ef082ab9c7e3cca40e809b0f29934 Gerrit-PatchSet: 6 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: David Ribeiro Alves <[email protected]> Gerrit-Reviewer: Dan Burkert <[email protected]> Gerrit-Reviewer: David Ribeiro Alves <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-Reviewer: Wes McKinney <[email protected]> Gerrit-HasComments: Yes
