Adar Dembo has posted comments on this change. Change subject: [c++ client] - Expose the schema being scanned in KuduScanBatch ......................................................................
Patch Set 1: (2 comments) I only looked at the public API changes. http://gerrit.cloudera.org:8080/#/c/2020/1/src/kudu/client/scan_batch.h File src/kudu/client/scan_batch.h: Line 84: const KuduSchema* projection_schema() const; Why expose this in KuduScanBatch/RowPtr and not in KuduScanner? It's a property of the entire scanner since (as you write) it's the same thing for each batch and row. This is the equivalent of KUDU-1269, right? Better to be consistent with the Java client, I think. http://gerrit.cloudera.org:8080/#/c/2020/1/src/kudu/client/schema.h File src/kudu/client/schema.h: Line 292: explicit KuduSchema(const Schema& schema); This shouldn't be part of the public API, because kudu::Schema is not a public class. -- To view, visit http://gerrit.cloudera.org:8080/2020 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id4276036d5ba7faf7959b4324fd013b68a08bec5 Gerrit-PatchSet: 1 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: David Ribeiro Alves <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-HasComments: Yes
