David Ribeiro Alves has posted comments on this change. Change subject: [c++ client] - Expose the schema being scanned in KuduScanBatch ......................................................................
Patch Set 4: (1 comment) http://gerrit.cloudera.org:8080/#/c/2020/4/src/kudu/client/scan_batch.h File src/kudu/client/scan_batch.h: Line 171: const KuduSchema* client_schema_; > hrm, I have some worries about the perf impacts of this. keeping the RowPtr the reason why this is exposed here vs the scan batch is that this was originally needed for the python client, which is still pegged to the old KuduRowResult and thus passes these around and not a KuduScanBatch. If you wish I can create a jira to fix it there and then get this out of here. -- To view, visit http://gerrit.cloudera.org:8080/2020 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id4276036d5ba7faf7959b4324fd013b68a08bec5 Gerrit-PatchSet: 4 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: David Ribeiro Alves <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: David Ribeiro Alves <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-HasComments: Yes
