Todd Lipcon has posted comments on this change.

Change subject: [python] - On writes, allow to set values to None
......................................................................


Patch Set 3:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/2031/3/python/kudu/client.pyx
File python/kudu/client.pyx:

Line 1159:             return
why don't we want to SetNull()? otherwise if we do: row['foo'] = 'bar' ; 
row['foo'] = None, it'll be left as bar, no?

also, do we want to support the __delete__ or whatever it's called? so del 
row['foo'] resets to "unset" which is different than NULL? (it takes default if 
the column has a default)


-- 
To view, visit http://gerrit.cloudera.org:8080/2031
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ic3c0e03caf76390497bcc464a1ebe508fbf33840
Gerrit-PatchSet: 3
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: David Ribeiro Alves <[email protected]>
Gerrit-Reviewer: Adar Dembo <[email protected]>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <[email protected]>
Gerrit-Reviewer: Wes McKinney <[email protected]>
Gerrit-HasComments: Yes

Reply via email to