Todd Lipcon has posted comments on this change. Change subject: Use signed column types in predicate_encoder-test ......................................................................
Patch Set 2: (4 comments) http://gerrit.cloudera.org:8080/#/c/2034/2/src/kudu/common/predicate_encoder-test.cc File src/kudu/common/predicate_encoder-test.cc: Line 108: // Predicate: a == 128 update this Line 142: // Predicate: b == 128 update Line 244: // Predicate: a == 128 here too Line 256: // Predicate: a == 128 AND b = "abc" here -- To view, visit http://gerrit.cloudera.org:8080/2034 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I351fa76b853900c92379b0918c61fec189ee2183 Gerrit-PatchSet: 2 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Dan Burkert <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-HasComments: Yes
