Jean-Daniel Cryans has posted comments on this change.

Change subject: KUDU-1296. Release notes for 0.7.0
......................................................................


Patch Set 1:

(10 comments)

http://gerrit.cloudera.org:8080/#/c/2062/1/docs/release_notes.adoc
File docs/release_notes.adoc:

Line 62: .. The C++ client has a new scanner API. The old way of using 
`vector<KuduRowResult>` is
> Nit: "old API of vector..." is more precise than "old way of using vector..
Done


Line 66: affected. Code that does note change this parameter when creating new 
tables and that assumes
> not, not note.
Used that instead and add "only 1 replica"


Line 70: and Java clients. It's is now recommended for use.
> Hmm, so what was the state of affairs earlier? Maybe say something like "it
The former seems better, I'll use that :P


Line 72: .. The foundation for a Spark integration was added. It contains a 
simple `kuduRDD` that wraps
> Nit: "a Spark integration" sounds a little weird. Is 'a' really necessary?
Sounds better in my head, but then again I think in French. Removing.


Line 80: .. An important file descriptor leak was fixed, it was triggered when 
tablets were deleted and
> Nit: An important file descriptor leak triggered when tablets were deleted 
But it is the only fix we know of for current 0.6.0/0.5.0 users so I'd rather 
list it.


Line 82: .. Inflight batches in the Java client could get stuck if the previous 
one encountered an error.
> Nit (singular/plural confusion): An inflight batch in the Java client could
Done


Line 84: .. Performance for the file block manager was improved but it's still 
not recommended to use it.
> Nit: still not recommended for production use.
Done


Line 85: .. The Master's catalog manager now tries to spread the tablets more 
evenly. This doesn't affect
> Nit: catalog manager is an implementation detail. I'd say: "The master now 
Done


Line 87: .. The licensing documents were changed in order to follow ASF 
guidelines.
> Nit: were changed to adhere to ASF guidelines.
Done


Line 88: .. Building Kudu can now be done out-of-tree but by default it still 
expects the "blessed
> There's not enough context for this to be useful information, and the relea
Makes sense.


-- 
To view, visit http://gerrit.cloudera.org:8080/2062
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ia3fa0aeffed578c64869facd6fc7aeee216bca3e
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Jean-Daniel Cryans
Gerrit-Reviewer: Adar Dembo <[email protected]>
Gerrit-Reviewer: David Ribeiro Alves <[email protected]>
Gerrit-Reviewer: Jean-Daniel Cryans
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Misty Stanley-Jones <[email protected]>
Gerrit-Reviewer: Todd Lipcon <[email protected]>
Gerrit-HasComments: Yes

Reply via email to