Mike Percy has posted comments on this change. Change subject: Specify full RUNPATH for thirdparty libs for compat with GNU gold ......................................................................
Patch Set 1: (2 comments) http://gerrit.cloudera.org:8080/#/c/2123/1//COMMIT_MSG Commit Message: Line 6: : Specify full RUNPATH for thirdparty libs for compat with GNU gold > I find this commit message confusing when compared to the actual code. I tried to condense the explanation. I've expanded it quite a bit. http://gerrit.cloudera.org:8080/#/c/2123/1/thirdparty/build-thirdparty.sh File thirdparty/build-thirdparty.sh: Line 158: EXTRA_LDFLAGS="-Wl,-rpath,$PREFIX/lib $EXTRA_LDFLAGS" > Please add a comment here explaining why we're setting -rpath. It would be Added some color here. -- To view, visit http://gerrit.cloudera.org:8080/2123 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic50b3667f96cec73497248751e9afc785e3f7979 Gerrit-PatchSet: 1 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Mike Percy <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Mike Percy <[email protected]> Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-HasComments: Yes
