Todd Lipcon has posted comments on this change.

Change subject: Allow to have more chains in linked_list-test
......................................................................


Patch Set 1:

(1 comment)

should we change the default? or have another test case which runs it with 
larger batches, if this reproduces different bugs?

http://gerrit.cloudera.org:8080/#/c/2125/1/src/kudu/integration-tests/linked_list-test-util.h
File src/kudu/integration-tests/linked_list-test-util.h:

Line 184:     CHECK_GE(chain_idx, 0);
shouldn't we retain an upper limit that it's 16-bit? otherwise chains will 
intersect


-- 
To view, visit http://gerrit.cloudera.org:8080/2125
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ideda1bfd130377792528d8bede1e7c44b4cf938f
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: David Ribeiro Alves <[email protected]>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <[email protected]>
Gerrit-HasComments: Yes

Reply via email to