David S. Wang has posted comments on this change.

Change subject: KUDU-1333. Add more packages to the RHEL installation 
documentation
......................................................................


Patch Set 3:

(4 comments)

> (1 comment)

http://gerrit.cloudera.org:8080/#/c/2179/3/docs/installation.adoc
File docs/installation.adoc:

Line 217:   gem git
> Please move gem as well. I don't think you need it for anything but ruby-de
yeah you are right, will move in the next patch


Line 231: . Optional: Install the ruby-devel package and the `asciidoctor` gem 
if you plan to build documentation.
> Hmm, the SLES12 portion of the doc is missing this section altogether.
I didn't test SLES 12 because I was being stupid and trying to launch in AWS 
directly instead of through CloudCat, and their SLES 12 image is borked.

I'd prefer not to add to the SLES 12 section with this patch, as I wasn't going 
to try other distros.


Line 321: $ sudo apt-get install git autoconf automake libboost-thread-dev \
> Don't need to install gem on Ubuntu or Debian?
Same comment as previous - I'd rather not add instructions that I didn't test 
out, and I don't have the cycles to install other distros.  I can file 
trivial-level JIRAs to track this.


Line 326: . Optional: Install the `asciidoctor` gem and xsltproc if you plan to 
build documentation.
> Presumably these need updating now too?
Same comment as previous - I'd rather not add instructions that I didn't test 
out, and I don't have the cycles to install other distros.  I can file 
trivial-level JIRAs to track this.


-- 
To view, visit http://gerrit.cloudera.org:8080/2179
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iae500ee037e3d1f2e73caf91485baf5ba3c54c36
Gerrit-PatchSet: 3
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: David S. Wang <[email protected]>
Gerrit-Reviewer: Adar Dembo <[email protected]>
Gerrit-Reviewer: David S. Wang <[email protected]>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Misty Stanley-Jones <[email protected]>
Gerrit-HasComments: Yes

Reply via email to