Todd Lipcon has posted comments on this change. Change subject: Integrate ColumnPredicate into client and server ......................................................................
Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#/c/2138/3/src/kudu/tserver/tserver.proto File src/kudu/tserver/tserver.proto: Line 249: repeated ColumnPredicatePB column_predicates = 13; > In this particular case we could add a little bit of logic to the client to yea, sending in both forms seems like a bit of a pain... I'm just worried about silently ignoring them. Let me screw around a bit to see if I can find a good generic solution for this kind of compat problem. The #grpc IRC people basically said "no, there is no silver bullet" :) -- To view, visit http://gerrit.cloudera.org:8080/2138 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ife6852680b7f59fddee688e5702c1a70944f7622 Gerrit-PatchSet: 3 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Dan Burkert <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Dan Burkert <[email protected]> Gerrit-Reviewer: David Ribeiro Alves <[email protected]> Gerrit-Reviewer: Jean-Daniel Cryans Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-HasComments: Yes
