Hello Dan Burkert,
I'd like you to do a code review. Please visit
http://gerrit.cloudera.org:8080/2246
to review the following change.
Change subject: Replace simpler instances of foo.Pass() with std::move(foo)
......................................................................
Replace simpler instances of foo.Pass() with std::move(foo)
This commit was done primarily via this perl script:
perl -p -i -e 's,([\w_]+)\.Pass\(\),std::move(\1),g' \
$(find src -name \*.h -or -name \*.cc)
with one or two trivial manual fixups where the regex went wrong and
introduced a syntax error. Additionally, I reverted the changes to
gutil/callback* and gutil/bind* since those files are complicated
and seemed to cause a lot of trouble.
Change-Id: Ibff7624f2d21ee098dfba466ebfbb09fd2c9862d
---
M src/kudu/benchmarks/tpch/tpch_real_world.cc
M src/kudu/cfile/bloomfile-test-base.h
M src/kudu/cfile/bloomfile-test.cc
M src/kudu/cfile/bloomfile.cc
M src/kudu/cfile/cfile-dump.cc
M src/kudu/cfile/cfile-test-base.h
M src/kudu/cfile/cfile-test.cc
M src/kudu/cfile/cfile_reader.cc
M src/kudu/cfile/cfile_writer.cc
M src/kudu/client/batcher.cc
M src/kudu/client/client-test.cc
M src/kudu/client/error-internal.cc
M src/kudu/consensus/consensus-test-util.h
M src/kudu/consensus/consensus.cc
M src/kudu/consensus/consensus_peers-test.cc
M src/kudu/consensus/consensus_peers.cc
M src/kudu/consensus/leader_election-test.cc
M src/kudu/consensus/leader_election.cc
M src/kudu/consensus/local_consensus.cc
M src/kudu/consensus/log-test-base.h
M src/kudu/consensus/log-test.cc
M src/kudu/consensus/log.cc
M src/kudu/consensus/mt-log-test.cc
M src/kudu/consensus/peer_manager.cc
M src/kudu/consensus/raft_consensus-test.cc
M src/kudu/consensus/raft_consensus.cc
M src/kudu/consensus/raft_consensus_quorum-test.cc
M src/kudu/consensus/raft_consensus_state-test.cc
M src/kudu/consensus/raft_consensus_state.cc
M src/kudu/fs/block_manager-test.cc
M src/kudu/fs/block_manager_util-test.cc
M src/kudu/fs/block_manager_util.h
M src/kudu/fs/fs-test-util.h
M src/kudu/fs/log_block_manager.cc
M src/kudu/gutil/gscoped_ptr.h
M src/kudu/gutil/move.h
M src/kudu/integration-tests/full_stack-insert-scan-test.cc
M src/kudu/master/catalog_manager.cc
M src/kudu/master/master.cc
M src/kudu/master/sys_catalog.cc
M src/kudu/rpc/connection.cc
M src/kudu/rpc/messenger.cc
M src/kudu/rpc/mt-rpc-test.cc
M src/kudu/rpc/outbound_call.cc
M src/kudu/rpc/rpc-test-base.h
M src/kudu/rpc/rpc_context.cc
M src/kudu/rpc/rpc_sidecar.h
M src/kudu/rpc/sasl_rpc-test.cc
M src/kudu/rpc/service_pool.cc
M src/kudu/server/rpc_server.cc
M src/kudu/server/server_base.cc
M src/kudu/tablet/cfile_set.cc
M src/kudu/tablet/compaction.cc
M src/kudu/tablet/delta_compaction-test.cc
M src/kudu/tablet/delta_compaction.cc
M src/kudu/tablet/delta_tracker.cc
M src/kudu/tablet/deltafile-test.cc
M src/kudu/tablet/deltafile.cc
M src/kudu/tablet/deltamemstore-test.cc
M src/kudu/tablet/diskrowset-test.cc
M src/kudu/tablet/diskrowset.cc
M src/kudu/tablet/memrowset.cc
M src/kudu/tablet/multi_column_writer.cc
M src/kudu/tablet/row_op.cc
M src/kudu/tablet/tablet-test.cc
M src/kudu/tablet/tablet.cc
M src/kudu/tablet/tablet_bootstrap-test.cc
M src/kudu/tablet/tablet_metadata.cc
M src/kudu/tablet/tablet_peer.cc
M src/kudu/tablet/transactions/transaction_driver.cc
M src/kudu/tablet/transactions/write_transaction.cc
M src/kudu/tools/fs_tool.cc
M src/kudu/tools/pbc-dump.cc
M src/kudu/tserver/tablet_server.cc
M src/kudu/tserver/tablet_service.cc
M src/kudu/twitter-demo/ingest_firehose.cc
M src/kudu/util/callback_bind-test.cc
M src/kudu/util/debug/trace_event_impl.cc
M src/kudu/util/pb_util-test.cc
M src/kudu/util/pb_util.cc
80 files changed, 245 insertions(+), 244 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/46/2246/1
--
To view, visit http://gerrit.cloudera.org:8080/2246
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ibff7624f2d21ee098dfba466ebfbb09fd2c9862d
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Todd Lipcon <[email protected]>
Gerrit-Reviewer: Dan Burkert <[email protected]>
