Dan Burkert has posted comments on this change. Change subject: Remove use of boost::ptr_vector in non-test code ......................................................................
Patch Set 1: (2 comments) http://gerrit.cloudera.org:8080/#/c/2243/1/src/kudu/cfile/bloomfile.cc File src/kudu/cfile/bloomfile.cc: Line 296: size += kudu_malloc_usable_size(&index_iters_[0]); this should be index_iters_.data(). http://gerrit.cloudera.org:8080/#/c/2243/1/src/kudu/cfile/index_btree.cc File src/kudu/cfile/index_btree.cc: Line 60: IndexBlockBuilder* idx_block = idx_blocks_[level].get(); Any reason you prefer a raw pointer to a reference here (and below)? -- To view, visit http://gerrit.cloudera.org:8080/2243 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ifb9b704cb3e65b8d1dc2605767c1eb29847b366d Gerrit-PatchSet: 1 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Todd Lipcon <[email protected]> Gerrit-Reviewer: Dan Burkert <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-HasComments: Yes
