Todd Lipcon has posted comments on this change. Change subject: arena: switch from shared_ptr components to unique_ptr ......................................................................
Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/2242/1/src/kudu/util/memory/arena.cc File src/kudu/util/memory/arena.cc: Line 145: arena_.push_back(std::move(last)); > this can be emplace_back, although it probably doesn't matter for unique_pt Done -- To view, visit http://gerrit.cloudera.org:8080/2242 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: If5218339809e6cb05461f978fe75860b97b01b61 Gerrit-PatchSet: 1 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Todd Lipcon <[email protected]> Gerrit-Reviewer: Dan Burkert <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-HasComments: Yes
