Todd Lipcon has posted comments on this change. Change subject: KUDU-1345. Fix case in which hybrid clock can run backwards ......................................................................
Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#/c/2266/3/src/kudu/server/hybrid_clock.h File src/kudu/server/hybrid_clock.h: Line 193: uint64_t next_timestamp_; > My other comments kind of touched on this: it would be nice if this could b the issue is that Timestamp is generic -- the logical clock also generates them, so we can't use member variables. We could have a HybridTimestamp class which is castable to/from Timestamp, but I think I prefer the C-style API here. We don't want to make the thing an interface with virtual dtor, etc, because the timestamps are passed around everywhere and being small and embeddable (rather than by pointer) is nice for perf. -- To view, visit http://gerrit.cloudera.org:8080/2266 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9b4a04cb8b7b5eb879d017375714b3183be0c601 Gerrit-PatchSet: 3 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Todd Lipcon <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: David Ribeiro Alves <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-HasComments: Yes
