Adar Dembo has posted comments on this change.

Change subject: [java] Integration test for ITBLL
......................................................................


Patch Set 2:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/2214/2/java/kudu-client-tools/src/test/java/org/kududb/mapreduce/tools/ITIntegrationTestBigLinkedList.java
File 
java/kudu-client-tools/src/test/java/org/kududb/mapreduce/tools/ITIntegrationTestBigLinkedList.java:

Line 29: public class ITIntegrationTestBigLinkedList extends BaseKuduTest {
> If the standard is to prefix the name of the class we're testing with IT, I
I don't follow your argument. The other two integration tests we have are named 
ITRowCounter and ITImportCsv, neither of which have "IntegrationTest" as part 
of the name.

If we call this ITBigLinkedList, isn't it clear that it's an integration test?


-- 
To view, visit http://gerrit.cloudera.org:8080/2214
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I1aeed74f7ab932feb99f6143c26bde7a5d7f1ba4
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Jean-Daniel Cryans
Gerrit-Reviewer: Adar Dembo <[email protected]>
Gerrit-Reviewer: Jean-Daniel Cryans
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <[email protected]>
Gerrit-HasComments: Yes

Reply via email to