Todd Lipcon has posted comments on this change. Change subject: KUDU-1343. [java client] Scan sequence id is never reset between tablets ......................................................................
Patch Set 1: (1 comment) maybe set the batch size on the scanner request RPC instead? http://gerrit.cloudera.org:8080/#/c/2301/1/java/kudu-client/src/test/java/org/kududb/client/MiniKuduCluster.java File java/kudu-client/src/test/java/org/kududb/client/MiniKuduCluster.java: Line 169: "--cfile_default_block_size=1024", I dont think the cfile block size should have any impact here. also not sure the flush threshold does either -- a single scanner batch can cross multiple rowsets -- To view, visit http://gerrit.cloudera.org:8080/2301 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iee05caa9157288e21475c64ade6a8dc7f6609665 Gerrit-PatchSet: 1 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Jean-Daniel Cryans Gerrit-Reviewer: Dan Burkert <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-HasComments: Yes
