Todd Lipcon has submitted this change and it was merged. Change subject: threadpool: prohibit shutdown and wait calls from pool member threads ......................................................................
threadpool: prohibit shutdown and wait calls from pool member threads If a thread pool thread calls a shutdown or wait function on its own pool, it'll deadlock. This patch introduces some checks that will turn the deadlock into a crash as well as a test to exercise it. The solution isn't particularly elegant, though I think it's less overhead than a TLS-based implementation. Change-Id: I1e00b251e0b798648b29d75c5cd82a25307129b4 Reviewed-on: http://gerrit.cloudera.org:8080/2013 Tested-by: Kudu Jenkins Reviewed-by: Todd Lipcon <[email protected]> --- M src/kudu/util/threadpool-test.cc M src/kudu/util/threadpool.cc M src/kudu/util/threadpool.h 3 files changed, 56 insertions(+), 2 deletions(-) Approvals: Todd Lipcon: Looks good to me, approved Kudu Jenkins: Verified -- To view, visit http://gerrit.cloudera.org:8080/2013 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: merged Gerrit-Change-Id: I1e00b251e0b798648b29d75c5cd82a25307129b4 Gerrit-PatchSet: 4 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Adar Dembo <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon <[email protected]>
