Adar Dembo has posted comments on this change. Change subject: KUDU-1325: more crash avoidance during remote bootstrap and tablet deletion ......................................................................
Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#/c/2265/3/src/kudu/util/make_shared.h File src/kudu/util/make_shared.h: Line 39: // about this when -Wmismatched-tags is set, which gcc doesn't support > what about wrapping the #pragma in an #ifdef to check for clang? Good idea, that did the trick! -- To view, visit http://gerrit.cloudera.org:8080/2265 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6a01c9e6886bd8bf0e286fc3980babc512056286 Gerrit-PatchSet: 3 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Adar Dembo <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Dan Burkert <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Mike Percy <[email protected]> Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-HasComments: Yes
