Todd Lipcon has posted comments on this change. Change subject: KUDU-1354. Writes should not release locks before committing MVCC ......................................................................
Patch Set 2: (3 comments) http://gerrit.cloudera.org:8080/#/c/2342/2/src/kudu/tablet/transactions/write_transaction.cc File src/kudu/tablet/transactions/write_transaction.cc: Line 265: TODO > isn't this what this method is doing? oops, forgot to remove the TODO after I did it :) Line 270: // After committing, the driver will respond to the RPC, which will > should probably add, "if there is an rpc going on" Done http://gerrit.cloudera.org:8080/#/c/2342/2/src/kudu/tablet/transactions/write_transaction.h File src/kudu/tablet/transactions/write_transaction.h: Line 144: // In the case of COMMIT, this method makes the inserts and mutations performed > probably want to change COMMIT to COMMITTED or Transaction::COMMITTED also Done -- To view, visit http://gerrit.cloudera.org:8080/2342 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie715e94f7b7e4848213d41c6837af574f5fa5d48 Gerrit-PatchSet: 2 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Todd Lipcon <[email protected]> Gerrit-Reviewer: David Ribeiro Alves <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-HasComments: Yes
