Todd Lipcon has posted comments on this change. Change subject: KUDU-1341 (part 1): improve tablet_random-access-test to be a full integration test ......................................................................
Patch Set 1: (7 comments) http://gerrit.cloudera.org:8080/#/c/2346/1/src/kudu/integration-tests/fuzz-itest.cc File src/kudu/integration-tests/fuzz-itest.cc: Line 48: enum TestOp { > doc Done Line 112: > extra line Done Line 244: void GenerateTestCase(vector<TestOp>* ops, int len) { > doc Done Line 336: int update_multiplier = 1) { > align Done Line 337: LOG(INFO) << "test case: " << DumpTestCase(test_ops); > more info or remove? this is just moved code. I'll add a comment explaining why it's useful though. Line 347: LOG(INFO) << TestOp_names[test_op]; > did you mean to leave this? vlog maybe? It's useful because if a randomized test fails, you want to know which operation it failed at. (also just moved code0 Line 431: // A particular test case which previously failed TestFuzz. > if you're not going to describe what this does maybe its not worth repeatin just moved code -- To view, visit http://gerrit.cloudera.org:8080/2346 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I4a60436461facbeb39aa4ff5f7b2ba1c2b7a230c Gerrit-PatchSet: 1 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Todd Lipcon <[email protected]> Gerrit-Reviewer: David Ribeiro Alves <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-HasComments: Yes
