Todd Lipcon has posted comments on this change.

Change subject: diskrowset: Fix reentrant acquisition of DiskRowSet 
component_lock
......................................................................


Patch Set 1:

right, using rwlock read side re-entrant is not safe (because there could 
always be a writer that comes along).

Would be great to somehow assert against it in debug mode, but would require a 
fair amount of cost (inserting the tid into a map or somesuch) so didn't want 
to go do that quite yet.

-- 
To view, visit http://gerrit.cloudera.org:8080/2375
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iee583a1442ac270238112427e37f2ec6565dfd38
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Todd Lipcon <[email protected]>
Gerrit-Reviewer: David Ribeiro Alves <[email protected]>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <[email protected]>
Gerrit-HasComments: No

Reply via email to