Todd Lipcon has posted comments on this change.

Change subject: KUDU-1337. Avoid spurious remote bootstraps on DeleteTablet()
......................................................................


Patch Set 1:

(2 comments)

http://gerrit.cloudera.org:8080/#/c/2436/1/src/kudu/tserver/ts_tablet_manager.cc
File src/kudu/tserver/ts_tablet_manager.cc:

Line 583:     // If the tablet was permanently deleted, then we can never 
transition it.
think it's worth copying a bit of the explanation in your commit message into 
the code here so we remember why we have this (to prevent flapping)


http://gerrit.cloudera.org:8080/#/c/2436/1/src/kudu/tserver/ts_tablet_manager.h
File src/kudu/tserver/ts_tablet_manager.h:

Line 327:   // restart).
nit: std::string in header


-- 
To view, visit http://gerrit.cloudera.org:8080/2436
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I852f8ac70e1f6496127598e5e02de5b72711ab2b
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Mike Percy <[email protected]>
Gerrit-Reviewer: Adar Dembo <[email protected]>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <[email protected]>
Gerrit-HasComments: Yes

Reply via email to