Hello Mike Percy,
I'd like you to do a code review. Please visit
http://gerrit.cloudera.org:8080/2484
to review the following change.
Change subject: Remove incorrectly applied or doubled ASF license headers
......................................................................
Remove incorrectly applied or doubled ASF license headers
The source header policy[1] says that you should not prepend the Apache
License when distributing work that is derived from projects under other
licenses. We have bits and pieces of code from LevelDB and RocksDB (BSD
license) which we'd previously prepended the ASF license to, but instead
should just keep the original license.
I briefly checked the 'git blame' on these files to see the extent to which
we'd modified them, and in some cases it was around 40-50% of the lines of
code, but none was rewritten to the extent that it's worth starting a discussion
on the subtleties of "major" vs "minor" modifications.
This also removes some cases in which we'd applied the Apache license twice
to the same piece of code -- in all cases in code we'd imported from Impala
at some point along the line after it was Apache licensed.
Change-Id: I8d8e781b672764a84792203b09e85c67e535dd11
---
M build-support/release/rat_exclude_files.txt
M src/kudu/server/default-path-handlers.cc
M src/kudu/server/default-path-handlers.h
M src/kudu/server/pprof-path-handlers.cc
M src/kudu/server/pprof-path-handlers.h
M src/kudu/server/webserver.cc
M src/kudu/server/webserver.h
M src/kudu/util/bit-stream-utils.h
M src/kudu/util/bit-stream-utils.inline.h
M src/kudu/util/bit-util-test.cc
M src/kudu/util/bit-util.h
M src/kudu/util/cache-test.cc
M src/kudu/util/cache.cc
M src/kudu/util/cache.h
M src/kudu/util/logging.cc
M src/kudu/util/logging.h
M src/kudu/util/nvm_cache.cc
M src/kudu/util/rle-encoding.h
M src/kudu/util/rle-test.cc
M src/kudu/util/status-test.cc
M src/kudu/util/sync_point.cc
M src/kudu/util/sync_point.h
M src/kudu/util/url-coding-test.cc
M src/kudu/util/url-coding.h
24 files changed, 18 insertions(+), 319 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/84/2484/1
--
To view, visit http://gerrit.cloudera.org:8080/2484
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I8d8e781b672764a84792203b09e85c67e535dd11
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Todd Lipcon <[email protected]>
Gerrit-Reviewer: Mike Percy <[email protected]>
