David Ribeiro Alves has posted comments on this change. Change subject: design-docs: multi-master for 1.0 release ......................................................................
Patch Set 1: (12 comments) http://gerrit.cloudera.org:8080/#/c/2527/1/docs/design-docs/multi-master-1.0.md File docs/design-docs/multi-master-1.0.md: Line 30: ## Gaps in the master good job with those markdown tags. Line 89: . this can also cause the cluster to be unbalanced right? maybe mention that Line 120: f points 2 and 3 seem even more serious than the title of the jira ticket. want to change the title/add more tickets? Line 130: ### These are the features to be implemented for 1.0 right? maybe mention that Line 147: XXX yeah probably remove Line 150: #### yeah likely file a ticket and leave this out Line 165: #### Table, tablet, and tserver metrics same Line 200: 2. All destructive actions taken by a tserver must be "fenced". That is, the only destructive or all the state changing operations? Line 201: takes s/takes/take Line 204: current master term they should keep an opid (i.e. term and index) instead of just term (would also account for ooo reception from the same master) Line 206: Ensure that the leader master replicates via Raft before triggering an : action. It doesn't matter what is replicated (a no-op would suffice); : a successful replication asserts that this master is still the leader. Need to think about this a bit further. I'm a bit worried that this is pointless without leader leases Line 212: partially replicated : operations are you talking about the ops that need more than one consensus round? didn't we discuss consolidating those? -- To view, visit http://gerrit.cloudera.org:8080/2527 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iad76012977a45370b72a04d608371cecf90442ef Gerrit-PatchSet: 1 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Adar Dembo <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: David Ribeiro Alves <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-HasComments: Yes
