David Ribeiro Alves has posted comments on this change. Change subject: wire_protocol-test: make string data more realistic ......................................................................
Patch Set 1: Code-Review+2 (1 comment) lgtm, up to you if you want to fix the nit http://gerrit.cloudera.org:8080/#/c/2532/1/src/kudu/common/wire_protocol-test.cc File src/kudu/common/wire_protocol-test.cc: Line 33: : schema_({ ColumnSchema("col1", STRING), nit:weird wrapping -- To view, visit http://gerrit.cloudera.org:8080/2532 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I22fc1b1a83ac57c819f320dce6ffc430ddf5662b Gerrit-PatchSet: 1 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Todd Lipcon <[email protected]> Gerrit-Reviewer: David Ribeiro Alves <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-HasComments: Yes
