Todd Lipcon has posted comments on this change. Change subject: KUDU-1336. Add a simple preflight check for thirdparty build ......................................................................
Patch Set 2: (6 comments) http://gerrit.cloudera.org:8080/#/c/2450/2/thirdparty/preflight.py File thirdparty/preflight.py: Line 25: more complicated config tests using something like autoconf or cmake. > You say that now...in five years take another look and tell me how it hasn' ok, I'll add a TODO dated for 3/18/2021 :) Line 52: with NamedTemporaryFile(suffix=".cc") as f: > Wouldn't you rather pass what you want to compile via STDIN? Cleaner, fewer Done Line 68: for tool in ["automake", "autoconf", "libtool", "pkg-config", "patch", > Nit: this list is probably the most likely thing to change in this script o Done Line 70: try_do( > If possible, it would be great to try all of these tools and provide one li Done Line 85: int main(int argc, char** argv) { > Don't need a main if you use -c in compile(). Not even sure if you need any wanted to make sure it can actually link (when trying to use custom toolchains sometimes we end up with the right headers but the wrong library for example) Will update the others that have empty main() Line 117: print "Pre-flight checks succeeded." > This sequence of checks is likely to grow over time. Could you decompose ea Done -- To view, visit http://gerrit.cloudera.org:8080/2450 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I93ee4165bd560f9cd3f03877bd3011decc7e1a6f Gerrit-PatchSet: 2 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Todd Lipcon <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Dan Burkert <[email protected]> Gerrit-Reviewer: Jean-Daniel Cryans Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-HasComments: Yes
