Todd Lipcon has posted comments on this change. Change subject: [java client] Allow ignore duplicate rows in auto flush sync mode ......................................................................
Patch Set 1: Code-Review+1 (3 comments) Someone else who knows the Java client well should probably review this, too. http://gerrit.cloudera.org:8080/#/c/2607/1/java/kudu-client/src/main/java/org/kududb/client/Operation.java File java/kudu-client/src/main/java/org/kududb/client/Operation.java: Line 86: void setIgnoreDuplicateRow(boolean ignoreDuplicateRow) { nit: this should be setIgnoreDuplicateRows (with an 's') to match the call in SessionConfiguration. Line 87: this.ignoreDuplicateRow = ignoreDuplicateRow; same for the variable names Line 89: nit: try to avoid trailing whitespace -- To view, visit http://gerrit.cloudera.org:8080/2607 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I671dd1bf537c2f5e6aa757883b350768081eb035 Gerrit-PatchSet: 1 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Binglin Chang <[email protected]> Gerrit-Reviewer: Jean-Daniel Cryans Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-HasComments: Yes
