Hello Mike Percy,
I'd like you to do a code review. Please visit
http://gerrit.cloudera.org:8080/2611
to review the following change.
Change subject: Suppress a TSAN error when multiple threads LOG(FATAL)
concurrently
......................................................................
Suppress a TSAN error when multiple threads LOG(FATAL) concurrently
glog internally has a 'fatal_msg_data_shared' global which is used
when more than two threads call LOG(FATAL) at the same time. This
results in races like:
WARNING: ThreadSanitizer: data race (pid=9726)
Write of size 8 at 0x7f288d596f98 by thread T121:
#0 localtime_r
/data1/jenkins-workspace/kudu-workspace/thirdparty/llvm-3.8.0.src/projects/compiler-rt/lib/tsan/../sanitizer_common/sanitizer_common_interceptors.inc:803
(kudu-tserver+0x000000438fc3)
#1 google::LogMessage::Init(char const*, int, int, void
(google::LogMessage::*)())
/data1/jenkins-workspace/kudu-workspace/thirdparty/glog-0.3.4/src/logging.cc:1215:3
(libglog.so.0+0x00000000a9c3)
I reported the issue upstream at https://github.com/google/glog/issues/80
but we can safely suppress it for now, as it only happens in the case
of LOG(FATAL)s.
Change-Id: I825da549c68d5226a8a3735aa6e43b407f258a8e
---
M build-support/tsan-suppressions.txt
1 file changed, 5 insertions(+), 0 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/11/2611/1
--
To view, visit http://gerrit.cloudera.org:8080/2611
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I825da549c68d5226a8a3735aa6e43b407f258a8e
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Todd Lipcon <[email protected]>
Gerrit-Reviewer: Mike Percy <[email protected]>
