On Wed, Mar 30, 2016 at 3:56 PM, Todd Lipcon <[email protected]> wrote:
> On Wed, Mar 30, 2016 at 3:47 PM, Jean-Daniel Cryans <[email protected]> > wrote: > > > On Wed, Mar 30, 2016 at 3:30 PM, Todd Lipcon <[email protected]> wrote: > > > > > I'd like to try to get http://gerrit.cloudera.org:8080/#/c/2641/3 > > > (earliest-deadline-first RPC scheduling) in as well. Without this, I'm > > > unable to handle concurrent TPC-H on machines with many cores. I think > > the > > > patch is ready for review though may need a couple test tweaks that > I'll > > > finish up today. > > > > > > > One thing that worries me, apart from the potential change in behavior > for > > those already using Kudu seriously, is that the new service queue doesn't > > have its own unit tests. It's good that it will pass all the same tests > we > > already have though. > > > > There is a new test which verifies the new behavior works properly. Plus as > you said, the RPC system is exercised by pretty much every integration > test, so I'd be surprised if the new class wasn't close to 100% coverage. > > If you want I can try to write a unit test for the queue itself outside the > context of RPC, but might be difficult without excessive mocking of the > InboundCall class. > Alright, you've convinced me. Also I like the fact that it was tested on a cluster already. +1 for 0.8.0. > > > > > > > > > > > -Todd > > > > > > On Wed, Mar 30, 2016 at 3:12 PM, Jean-Daniel Cryans < > [email protected] > > > > > > wrote: > > > > > > > I forgot: > > > > > > > > KUDU-1377 http://gerrit.cloudera.org:8080/#/c/2595/ > > > > > > > > is +1 for 0.8.0 too. > > > > > > > > J-D > > > > > > > > On Wed, Mar 30, 2016 at 2:47 PM, Jean-Daniel Cryans < > > [email protected] > > > > > > > > wrote: > > > > > > > > > Branching is done. > > > > > > > > > > On Wed, Mar 30, 2016 at 1:54 PM, Jean-Daniel Cryans < > > > [email protected] > > > > > > > > > > wrote: > > > > > > > > > >> Hey devs, > > > > >> > > > > >> As planned, I will be creating today a "branch-0.8.x" branch that > > > we'll > > > > >> be releasing 0.8.0 from. Expect this to happen within an hour or > > two. > > > > >> > > > > >> Being the RM, I'm pre-authorizing the following patches to be > > > > >> cherry-picked to branch-0.8.x when they are ready: > > > > >> > > > > >> Java's KuduPredicate API: > http://gerrit.cloudera.org:8080/#/c/2591/ > > > > >> Release and upgrade notes: > > http://gerrit.cloudera.org:8080/#/c/2655/ > > > > >> KUDU-1380 scans that rewind: > > > http://gerrit.cloudera.org:8080/#/c/2654/ > > > > >> > > > > >> For anything else, please reply to this thread with a link to the > > > review > > > > >> before cherry-picking to the new branch in order to get my +1. > > > > >> > > > > >> I'll also reply here once the branching is done. > > > > >> > > > > >> Thx, > > > > >> > > > > >> J-D > > > > >> > > > > > > > > > > > > > > > > > > > > > > > > > > -- > > > Todd Lipcon > > > Software Engineer, Cloudera > > > > > > > > > -- > Todd Lipcon > Software Engineer, Cloudera >
