Adar Dembo has posted comments on this change. Change subject: KUDU-495 (part 1): new sys_catalog writing API ......................................................................
Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/2648/2/src/kudu/master/sys_catalog.h File src/kudu/master/sys_catalog.h: Line 96: // Perform a series of table/tablet actions in one WriteTransaction. > rephrase to something like: Series of table/tablet actions to perform to th Actually, I structured it this way on purpose. It's like this: 1. Empty line 2. Comment 3. Struct declaration 4. Function declaration 5. Empty line With this structure, I am trying to emphasize that the struct is "scoped" to just this one function, and that the comment applies to both. I agree that if you read the comment as applying to just the struct, it's pretty weird. But it should actually be read as applying to the function, and to helping to explain the struct too. Hope that makes sense. I don't feel strongly about it, but it was intentional stylistic choice on my part. -- To view, visit http://gerrit.cloudera.org:8080/2648 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I7f5e5ecbff33435c964ced2e421566c41c387e9e Gerrit-PatchSet: 2 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Adar Dembo <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: David Ribeiro Alves <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-HasComments: Yes
