Jean-Daniel Cryans has submitted this change and it was merged. Change subject: Add internal IS NOT NULL predicate type ......................................................................
Add internal IS NOT NULL predicate type This commit adds an internal IS NOT NULL predicate type, and changes LESS_EQUAL predicate simplification to result in the IS NOT NULL predicate type when the conversion to a LESS predicate fails and the column is nullable. This fixes scans with predicates such as 'WHERE my_nullable_int8_col <= 127`. A followup commit will contain comprehensive predicate tests covering this case. Change-Id: Ifcf29b1f274df2ef5c5ac7a7a17cc06dfd59e191 Reviewed-on: http://gerrit.cloudera.org:8080/2671 Reviewed-by: Todd Lipcon <[email protected]> Tested-by: Kudu Jenkins (cherry picked from commit 9b8b020210905b0cc4dd81e0ca905e098d0cad33) Reviewed-on: http://gerrit.cloudera.org:8080/2681 Reviewed-by: Jean-Daniel Cryans --- M src/kudu/client/scan_predicate.cc M src/kudu/client/scanner-internal.cc M src/kudu/common/column_predicate-test.cc M src/kudu/common/column_predicate.cc M src/kudu/common/column_predicate.h M src/kudu/common/common.proto M src/kudu/tserver/tablet_service.cc 7 files changed, 120 insertions(+), 8 deletions(-) Approvals: Jean-Daniel Cryans: Looks good to me, approved Kudu Jenkins: Verified -- To view, visit http://gerrit.cloudera.org:8080/2681 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ifcf29b1f274df2ef5c5ac7a7a17cc06dfd59e191 Gerrit-PatchSet: 2 Gerrit-Project: kudu Gerrit-Branch: branch-0.8.x Gerrit-Owner: Dan Burkert <[email protected]> Gerrit-Reviewer: Jean-Daniel Cryans Gerrit-Reviewer: Kudu Jenkins
