Jean-Daniel Cryans has submitted this change and it was merged. Change subject: Change row projector schema equality check to use physical column type ......................................................................
Change row projector schema equality check to use physical column type The row projector uses the column's physical type (e.g. for TIMESTAMP the physical type is INT64) to build codegen cache keys, but used the normal column type when comparing the projection schemas retrieved from the cache. This resulted in spurious debug check failures. Change-Id: I5e9a8d9c003be3942d3ce6f93d880adb45d8ded6 Reviewed-on: http://gerrit.cloudera.org:8080/2672 Reviewed-by: Todd Lipcon <[email protected]> Tested-by: Kudu Jenkins (cherry picked from commit 8f4726d83e6b6b7d76c59d06fde9231f0bb113b9) Reviewed-on: http://gerrit.cloudera.org:8080/2682 Reviewed-by: Jean-Daniel Cryans --- M src/kudu/codegen/row_projector.cc M src/kudu/common/schema.h 2 files changed, 8 insertions(+), 3 deletions(-) Approvals: Jean-Daniel Cryans: Looks good to me, approved Kudu Jenkins: Verified -- To view, visit http://gerrit.cloudera.org:8080/2682 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: merged Gerrit-Change-Id: I5e9a8d9c003be3942d3ce6f93d880adb45d8ded6 Gerrit-PatchSet: 2 Gerrit-Project: kudu Gerrit-Branch: branch-0.8.x Gerrit-Owner: Dan Burkert <[email protected]> Gerrit-Reviewer: Jean-Daniel Cryans Gerrit-Reviewer: Kudu Jenkins
