Mike Percy has posted comments on this change. Change subject: env: Implement RWFile::Truncate() ......................................................................
Patch Set 1: (2 comments) http://gerrit.cloudera.org:8080/#/c/2697/1/src/kudu/util/env.h File src/kudu/util/env.h: Line 446: // null bytes ('\0'). > In the extending case, is the behavior the same as PreAllocate? Or is PreAl They're actually different. I'll update the comments. http://gerrit.cloudera.org:8080/#/c/2697/1/src/kudu/util/env_posix.cc File src/kudu/util/env_posix.cc: Line 68: #define RETRY_ON_EINTR(ret, expr) do { \ > Not a bad idea, but why worry about it now? Shouldn't it apply to any sysca Well, I know it applies to ftruncate(). It wouldn't be a bad idea to go through and apply this to the others as well, later. -- To view, visit http://gerrit.cloudera.org:8080/2697 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1f189df33e7c7afdd50d76d60be0acd6ff5d5820 Gerrit-PatchSet: 1 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Mike Percy <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Mike Percy <[email protected]> Gerrit-HasComments: Yes
