Todd Lipcon has posted comments on this change. Change subject: KUDU-1387. Fix a case where the scanner tight-loops and then sleeps too long ......................................................................
Patch Set 2: (4 comments) http://gerrit.cloudera.org:8080/#/c/2699/2//COMMIT_MSG Commit Message: Line 14: - in the tablet lookup patch, RemoteTablet::HasLeader() returns false because > Nit: path, not patch? Done http://gerrit.cloudera.org:8080/#/c/2699/2/src/kudu/client/client-test.cc File src/kudu/client/client-test.cc: Line 2159: ASSERT_LT(master_rpcs, 20); > Why 20? Maybe explain in the comment? Done http://gerrit.cloudera.org:8080/#/c/2699/2/src/kudu/client/scanner-internal.cc File src/kudu/client/scanner-internal.cc: Line 227 > Let me make sure I understand why you're removing this. Without it, we'll r yes, exactly. Line 349: blacklist->clear(); > Would it make things more clear if we summarized the blacklist usage up-fro I added a little comment here to try to clarify. Agree this code can be generally improved/redesigned - the next patch in this series makes some progress in that direction. -- To view, visit http://gerrit.cloudera.org:8080/2699 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3cb3afa81cd6f75756c328b6ffe23a385f4b172d Gerrit-PatchSet: 2 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Todd Lipcon <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-HasComments: Yes
