Todd Lipcon has submitted this change and it was merged. Change subject: KUDU-1380. Fix retry for BUSY on non-FT scans ......................................................................
KUDU-1380. Fix retry for BUSY on non-FT scans This cleans up the code paths for error handling in Scan RPCs to make it much easier to follow and eliminate duplicated code. In the process, it fixes a bug where we would incorrectly re-open a tablet upon receiving SERVER_TOO_BUSY errors. The tablet reopening behavior would result in the scanner rewinding to the beginning of the tablet and yielding the same rows that had already previously been returned to the user. The test modification increases the number of rows to be scanned in the fault tolerance test, and also adds an assertion that the number of rows returned matches the number inserted. This would fail reliably without the bug fix. Change-Id: I048d3aa2a163143d1637ae87281ed91f0fc5ac65 Reviewed-on: http://gerrit.cloudera.org:8080/2654 Reviewed-by: Adar Dembo <[email protected]> Tested-by: Kudu Jenkins --- M src/kudu/client/client-test.cc M src/kudu/client/client.cc M src/kudu/client/scanner-internal.cc M src/kudu/client/scanner-internal.h 4 files changed, 268 insertions(+), 203 deletions(-) Approvals: Adar Dembo: Looks good to me, approved Kudu Jenkins: Verified -- To view, visit http://gerrit.cloudera.org:8080/2654 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: merged Gerrit-Change-Id: I048d3aa2a163143d1637ae87281ed91f0fc5ac65 Gerrit-PatchSet: 6 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Todd Lipcon <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Jean-Daniel Cryans Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon <[email protected]>
