Todd Lipcon has posted comments on this change. Change subject: KUDU-1406: Fix empty kudu.master_addresses in TBLPROPERTIES via Web UI - all_addresses is a vector<string> that is defined but never initialized. The empty all_addresses is then assigned incorrectly to master_addresses. This patch correctly initializes an ......................................................................
Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/2744/1//COMMIT_MSG Commit Message: Line 8: - all_addresses is a vector<string> that is defined but never initialized. The empty all_addresses is then assigned small nit: best to add an extra blank line between the first line of the commit message and the content, so it shows up nicer in git logs, etc. I'll reformat for you to avoid the trouble of re-uploading. -- To view, visit http://gerrit.cloudera.org:8080/2744 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5a8930330dce2b255ec49a1ab95e1caf37f5bf00 Gerrit-PatchSet: 1 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Sameer Abhyankar <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-HasComments: Yes
