Jean-Daniel Cryans has posted comments on this change. Change subject: [java-client] implement scan token API ......................................................................
Patch Set 8: (2 comments) http://gerrit.cloudera.org:8080/#/c/2592/8/java/kudu-client/src/main/java/org/kududb/client/Bytes.java File java/kudu-client/src/main/java/org/kududb/client/Bytes.java: Line 28: import com.google.common.base.Preconditions; Still required? http://gerrit.cloudera.org:8080/#/c/2592/8/java/kudu-client/src/test/java/org/kududb/client/TestKuduClient.java File java/kudu-client/src/test/java/org/kududb/client/TestKuduClient.java: Line 379: latch.await(10, TimeUnit.SECONDS); Should you assert false? -- To view, visit http://gerrit.cloudera.org:8080/2592 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I20eff9bf51e893226fc3bc47726565ca62c054e3 Gerrit-PatchSet: 8 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Dan Burkert <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Dan Burkert <[email protected]> Gerrit-Reviewer: David Ribeiro Alves <[email protected]> Gerrit-Reviewer: Jean-Daniel Cryans Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-HasComments: Yes
